search

mitchellh / vagrant-rackspace

Use Vagrant to manage Rackspace Cloud instances.
MIT License
236 stars 155 forks source link

Confirm Rackspace server destruction. #116

Closed dkinzer closed 10 years ago

dkinzer commented 10 years ago

This pull request implements a fix for mitchellh/vagrant-rackspace#114

maxlinc commented 10 years ago

Wow... I got so used to typing "vagrant destroy -f" I never even noticed the -f didn't matter.

@smashwilson LGTM. Should be backwards compatible all the way back to Vagrant 1.2.2.

smashwilson commented 10 years ago

@smashwilson LGTM. Should be backwards compatible all the way back to Vagrant 1.2.2.

Good enough for me!

dkinzer commented 10 years ago

@maxlinc yeah, I was rather surprised too, and completely caught off guard.

I had set up a multi environment Vagrantfile and I needed to shed some VM weight off. I was relying on the confirmation to skip stuff I actually wanted to keep around and then the Rackspace stuff just disappeared without any confirmation. Ugh.

Fortunately it wasn't too much of a hassle to spin up the server again an get it provisioned, but I still...

dkinzer commented 10 years ago

@smashwilson I noticed that this was asking but not actually skipping so UI forced pushed "fix" but it's wrong ... I need to redo ... sorry, thought I had time to fix it before anyone would merge it.

dkinzer commented 10 years ago

I.e I forgot to require

uninitialized constant VagrantPlugins::Rackspace::Action::MessageWillNotDestroy