search

mitchellh / vagrant-rackspace

Use Vagrant to manage Rackspace Cloud instances.
MIT License
236 stars 155 forks source link

Set box_optional and parallel attributes #128

Closed maxlinc closed 9 years ago

maxlinc commented 9 years ago

Fixes #127 and #126.

maxlinc commented 9 years ago

Currently the PR doesn't address the UX concern:

The only issue I know of is a minor UX one - the server build progress indicator (e.g. Progress: 80%) is not designed to report the status of multiple machines being built simultaneously. I think that's a relatively minor issue: other providers don't provide a progress indicator at all, and I think most people just use it as an indicator that the action hasn't hung.

If there's a threadsafe way to get aggregate progress information then I'm thinking about an indicator like:

3/5 server built; slowest (some_server_name) 20%

If not, then either:

maxlinc commented 9 years ago

Ok, this is good now. I changed the progress report so it'll include the server name prefix. It does have some issues w/ newlines which aren't easily avoided (because of the use of clear_line). It looks like:

==> windows: Waiting for the server to be built...
==> windows: Progress: 0%==> centos: Waiting for the server to be built...
==> centos: Progress: 0%==> ubuntu: Waiting for the server to be built...
==> centos: Progress 80%

The last line will flicker between different servers. In this case, between centos/ubuntu/windows.

If anyone has an idea to refine it further they can update the report_server_progress method.

smashwilson commented 9 years ago

:+1: Sounds reasonable to me.