mitchellh / virtualbox

[ABANDONED] Create and modify virtual machines in VirtualBox using pure ruby.
http://mitchellh.github.com/virtualbox/
MIT License
245 stars 45 forks source link

access_mode types are inconsistent #55

Closed geemus closed 13 years ago

geemus commented 13 years ago

Other types do not include their type name, for instance, the enum for BandwidthGroupType looks like this: [:null, :disk, :network] rather than this: [:bandwidth_group_null, :bandwidth_group_disk, :bandwidth_group_network]

access_mode looks like this: [:null, :access_mode_read_only, :access_mode_read_write] but it seems like it would be more consistent with other enums if it was like this instead: [:null, :read_only, :read_write]

Happy to make this change, but felt like it would be better to just bring it up and there are likely to be repercussions if the change were made.