search

mitchellkrogza / nginx-ultimate-bad-bot-blocker

Nginx Block Bad Bots, Spam Referrer Blocker, Vulnerability Scanners, User-Agents, Malware, Adware, Ransomware, Malicious Sites, with anti-DDOS, Wordpress Theme Detector Blocking and Fail2Ban Jail for Repeat Offenders
Other
3.97k stars 477 forks source link

Duplicate network #191

Closed shanemarsh28 closed 5 years ago

shanemarsh28 commented 6 years ago

Hi,

Fabulous work bte - really loving this bad bot blocker!

I noticed something popup when reloading Nginx...

nginx: [warn] duplicate network "104.5.92.27", value: "1", old value: "1" in /nginx/ngxblocker/conf.d/globalblacklist.conf:7514 nginx: [warn] duplicate network "185.119.81.11", value: "1", old value: "1" in /nginx/ngxblocker/conf.d/globalblacklist.conf:8290 nginx: [warn] duplicate network "185.86.13.213", value: "1", old value: "1" in /nginx/ngxblocker/conf.d/globalblacklist.conf:8410 nginx: [warn] duplicate network "31.170.160.209", value: "1", old value: "1" in /nginx/ngxblocker/conf.d/globalblacklist.conf:8966

itoffshore commented 6 years ago

@shanemarsh28 - see https://github.com/mitchellkrogza/nginx-ultimate-bad-bot-blocker/issues/189 for a quick fix.

I need to add a function to update all files instead of just the globalbacklist.conf to fix this type of error properly

mitchellkrogza commented 6 years ago

Glad the blocker is helping you, please see this issue to fix that warning message https://github.com/mitchellkrogza/nginx-ultimate-bad-bot-blocker/issues/189

mitchellkrogza commented 6 years ago

@itoffshore that would be a great addition to the update need.to consider though not to overwrite those who have already customized their own blacklist

itoffshore commented 6 years ago

I think user additions should go into a globalblacklist.local which gets sourced by globalblacklist.conf as it is normally updated by cron

mitchellkrogza commented 6 years ago

Good idea @itoffshore will have to think of how to include that without breaking any existing installations out there who manually update.

shanemarsh28 commented 6 years ago

Thanks everyone for your comments. It's very refreshing to see helpful comments and positivity!

I will follow itoffshore's recommendations to resolve this particular warning and I'll look forward to your future releases.

Lovely work guys! :)

mitchellkrogza commented 6 years ago

Thanks @shanemarsh28 hope you have resolved the nginx warning, can I close this issue?

mitchellkrogza commented 5 years ago

Closing due to no activity, feel free to reopen

mdestafadilah commented 8 months ago

still duplicate network