search

mitchellkrogza / nginx-ultimate-bad-bot-blocker

Nginx Block Bad Bots, Spam Referrer Blocker, Vulnerability Scanners, User-Agents, Malware, Adware, Ransomware, Malicious Sites, with anti-DDOS, Wordpress Theme Detector Blocking and Fail2Ban Jail for Repeat Offenders
Other
3.97k stars 477 forks source link

Add option to suppress scripts-update (only update rules/config). #351

Closed netchild closed 4 years ago

netchild commented 4 years ago

For package management systems where the installed scripts/binaries shall not be modified externally (not by the package management system).

auto-comment[bot] commented 4 years ago

Thank your for raising your pull request. Please make sure you have followed our contributing guidelines. We will review it as soon as possible

netchild commented 4 years ago

I assume you reverted all commits which were done in the timeframe around the breakage. This one is not the one which broke it. So the revert can be reverted. The other one with the stupid mistake in the linux case I have resubmitted with a fix.

itoffshore commented 4 years ago

I reverted this PR as it had a mistake & at the moment there is no update functionality for the helper scripts to suppress (& if implemented it would be in update-ngxblocker as that contains the code for checking versioning) - install-ngxblocker is supposed to only be run once

After the breakage on the recent merges perhaps it is better not to add functionality to update the helper scripts - any changes to them now should be rare & version updates are better done as part of a distribution package