search

mitchellkrogza / nginx-ultimate-bad-bot-blocker

Nginx Block Bad Bots, Spam Referrer Blocker, Vulnerability Scanners, User-Agents, Malware, Adware, Ransomware, Malicious Sites, with anti-DDOS, Wordpress Theme Detector Blocking and Fail2Ban Jail for Repeat Offenders
Other
3.97k stars 477 forks source link

[BUG] Configuration files doesn't respect installer arguments #479

Closed message closed 2 years ago

message commented 2 years ago

Describe the bug

Configuration files still have /etc/nginx/ path even though different bots and conf parameters are passed to installer.

To Reproduce

Steps to reproduce the behavior:

/usr/local/sbin/install-ngxblocker -b /etc/nginx-rc/bots.d -c /etc/nginx-rc/conf.d -x

Result:

root@host:/etc/nginx-rc# grep -R '/etc/nginx/'
conf.d/botblocker-nginx-settings.conf:#     include /etc/nginx/conf.d/*
conf.d/globalblacklist.conf:    include /etc/nginx/bots.d/blacklist-user-agents.conf;
conf.d/globalblacklist.conf:# You can over-ride these in /etc/nginx/bots.d/blacklist-user-agents.conf
conf.d/globalblacklist.conf:# You can over-ride these in /etc/nginx/bots.d/blacklist-user-agents.conf
conf.d/globalblacklist.conf:    include /etc/nginx/bots.d/whitelist-domains.conf;
conf.d/globalblacklist.conf:    include /etc/nginx/bots.d/bad-referrer-words.conf;
conf.d/globalblacklist.conf:# /etc/nginx/bots.d/custom-bad-referrers.conf
conf.d/globalblacklist.conf:    include /etc/nginx/bots.d/whitelist-domains.conf;
conf.d/globalblacklist.conf:    include /etc/nginx/bots.d/custom-bad-referrers.conf;
conf.d/globalblacklist.conf:    include /etc/nginx/bots.d/blacklist-ips.conf;
conf.d/globalblacklist.conf:    include /etc/nginx/bots.d/whitelist-ips.conf;
conf.d/globalblacklist.conf:    include /etc/nginx/bots.d/whitelist-ips.conf;
bots.d/ddos.conf:#          include /etc/nginx/bots.d/blockbots.conf
bots.d/ddos.conf:#          include /etc/nginx/bots.d/ddos.conf
bots.d/blockbots.conf:#         include /etc/nginx/bots.d/blockbots.conf
bots.d/blockbots.conf:#         include /etc/nginx/bots.d/ddos.conf

Expected behavior

Should have correct path /etc/nginx-rc/*

conf.d/botblocker-nginx-settings.conf:#     include /etc/nginx-rc/conf.d/*
conf.d/globalblacklist.conf:    include /etc/nginx-rc/bots.d/blacklist-user-agents.conf;
conf.d/globalblacklist.conf:# You can over-ride these in /etc/nginx-rc/bots.d/blacklist-user-agents.conf
conf.d/globalblacklist.conf:# You can over-ride these in /etc/nginx-rc/bots.d/blacklist-user-agents.conf
conf.d/globalblacklist.conf:    include /etc/nginx-rc/bots.d/whitelist-domains.conf;
conf.d/globalblacklist.conf:    include /etc/nginx-rc/bots.d/bad-referrer-words.conf;
conf.d/globalblacklist.conf:# /etc/nginx-rc/bots.d/custom-bad-referrers.conf
conf.d/globalblacklist.conf:    include /etc/nginx-rc/bots.d/whitelist-domains.conf;
conf.d/globalblacklist.conf:    include /etc/nginx-rc/bots.d/custom-bad-referrers.conf;
conf.d/globalblacklist.conf:    include /etc/nginx-rc/bots.d/blacklist-ips.conf;
conf.d/globalblacklist.conf:    include /etc/nginx-rc/bots.d/whitelist-ips.conf;
conf.d/globalblacklist.conf:    include /etc/nginx-rc/bots.d/whitelist-ips.conf;
bots.d/ddos.conf:#          include /etc/nginx-rc/bots.d/blockbots.conf
bots.d/ddos.conf:#          include /etc/nginx-rc/bots.d/ddos.conf
bots.d/blockbots.conf:#         include /etc/nginx-rc/bots.d/blockbots.conf
bots.d/blockbots.conf:#         include /etc/nginx-rc/bots.d/ddos.conf

Server:

Linux vmi908611 5.4.0-105-generic #119-Ubuntu SMP Mon Mar 7 18:49:24 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

nginx version: nginx-rc/1.19.9.1

mitchellkrogza commented 2 years ago

If you are using a non standard location for nginx please follow manual installation guide as any distro uses /etc/nginx/ all the installer does is allow you to change the location of conf.d and bots.d folders nested under /etc/nginx