search

mitchelloharawild / distributional

Vectorised distributions for R
https://pkg.mitchelloharawild.com/distributional
GNU General Public License v3.0
94 stars 15 forks source link

Merged distribution docs from distributions3 #39

Closed mitchelloharawild closed 4 years ago

mitchelloharawild commented 4 years ago

From Twitter:

ideally we'd copy our documentation over and merge, keeping {distributions3} around for a while since people use it to teach. https://twitter.com/alexpghayes/status/1277653857385021445, @alexpghayes

This PR merges the very nice distribution documentation from the {distributions3} package.

@alexpghayes, I've added you as author for this substantial contribution. If you'd like, I can also allow you collaborator access to this repository. Could you briefly review these changes, and approve the PR if appropriate?

At a later point, it would be nice to merge some vignettes from {distributions3}. However for now I plan to focus on the functions and data structures (and less on using the package as a teaching tool, although I will be teaching with it next semester so priorities may change).

alexpghayes commented 4 years ago

Thrilled to see this! Will take a look this evening!

On Tue, Jul 21, 2020, 9:12 AM mitchelloharawild notifications@github.com wrote:

From Twitter:

ideally we'd copy our documentation over and merge, keeping {distributions3} around for a while since people use it to teach. https://twitter.com/alexpghayes/status/1277653857385021445, @alexpghayes https://github.com/alexpghayes

This PR merges the very nice distribution documentation from the {distributions3} package.

@alexpghayes https://github.com/alexpghayes, I've added you as author for this substantial contribution. If you'd like, I'd be allow you collaborator access to this repository. Could you briefly review these changes, and approve the PR if appropriate?

At a later point, it would be nice to merge some vignettes from {distributions3}. However for now I plan to focus on the functions and data structures (and less on using the package as a teaching tool, although I will be teaching with it next semester so priorities may change).

You can view, comment on, or merge this pull request online at:

https://github.com/mitchelloharawild/distributional/pull/39 Commit Summary

  • Merged distribution docs from distributions3

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mitchelloharawild/distributional/pull/39, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTBG2YUIAZJO6SJ7LYNC2LR4WO5LANCNFSM4PDUQOLA .

alexpghayes commented 4 years ago

Took a look and I'm onboard. My only comment is that a number of other people wrote portions of this documentation, although I'm not sure exactly who and in what proportions, so it may be worth glancing through the git history to see if there are other people to list as contributors.

mitchelloharawild commented 4 years ago

Great, thanks. I'll look through the history and update authors as appropriate.