mitchelloharawild / distributional

Vectorised distributions for R
https://pkg.mitchelloharawild.com/distributional
GNU General Public License v3.0
94 stars 15 forks source link

make variance() return variance (not covariance) on matrices, closes #55 #56

Closed mjskay closed 3 years ago

mjskay commented 3 years ago

This PR closes #55 via:

Thanks for considering this and let me know if you'd like any changes.

codecov-commenter commented 3 years ago

Codecov Report

Merging #56 (1bff88b) into master (ab2fd9e) will increase coverage by 0.16%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   62.91%   63.07%   +0.16%     
==========================================
  Files          45       45              
  Lines        1305     1308       +3     
==========================================
+ Hits          821      825       +4     
+ Misses        484      483       -1     
Impacted Files Coverage Δ
R/distribution.R 47.10% <100.00%> (+2.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab2fd9e...1bff88b. Read the comment docs.

mjskay commented 3 years ago

Note: the CHECK failure on R 3.5 is due to ggdist not being installed, which is due to fda not working on 3.5. fda was a dependency of ggdist for a brief time but is now in Suggests (that change hasn't hit CRAN yet though). Anyway, the upshot is that the failure in R 3.5 has nothing to do with this PR (which passes on all other R versions).