mitchelloharawild / vitae

R Markdown Résumés and CVs
https://pkg.mitchelloharawild.com/vitae/
1.23k stars 239 forks source link

No footer in awesomecv template #207

Closed atsyplenkov closed 2 years ago

atsyplenkov commented 2 years ago

Hi all,

after upgrading to R 4.2 (and possible upgrade of vitae package) I cannot replicate an awesomecv template. The output is missing a footer with date, name and page number. Is it a bug?

image

My sessionInfo:

R version 4.2.0 (2022-04-22 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19042)

Matrix products: default

locale:
[1] LC_COLLATE=Russian_Russia.utf8  LC_CTYPE=Russian_Russia.utf8   
[3] LC_MONETARY=Russian_Russia.utf8 LC_NUMERIC=C                   
[5] LC_TIME=Russian_Russia.utf8    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] knitr_1.39       magrittr_2.0.3   tidyselect_1.1.2 R6_2.5.1        
 [5] rlang_1.0.2      fastmap_1.1.0    fansi_1.0.3      dplyr_1.0.9     
 [9] tools_4.2.0      xfun_0.31        utf8_1.2.2       cli_3.3.0       
[13] DBI_1.1.2        htmltools_0.5.2  ellipsis_0.3.2   yaml_2.3.5      
[17] digest_0.6.29    assertthat_0.2.1 tibble_3.1.7     lifecycle_1.0.1 
[21] crayon_1.5.1     purrr_0.3.4      vctrs_0.4.1      glue_1.6.2      
[25] evaluate_0.15    rmarkdown_2.14   compiler_4.2.0   pillar_1.7.0    
[29] generics_0.1.2   vitae_0.5.1.9000 pkgconfig_2.0.3 
atsyplenkov commented 2 years ago

Same problem and on the Ubuntu machine. I've used Rstudio Cloud to replicate the example Marie Curie template

Here is the SessionInfo

R version 4.2.0 (2022-04-22)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 20.04.4 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/atlas/libblas.so.3.10.3
LAPACK: /usr/lib/x86_64-linux-gnu/atlas/liblapack.so.3.10.3

locale:
 [1] LC_CTYPE=C.UTF-8       LC_NUMERIC=C           LC_TIME=C.UTF-8       
 [4] LC_COLLATE=C.UTF-8     LC_MONETARY=C.UTF-8    LC_MESSAGES=C.UTF-8   
 [7] LC_PAPER=C.UTF-8       LC_NAME=C              LC_ADDRESS=C          
[10] LC_TELEPHONE=C         LC_MEASUREMENT=C.UTF-8 LC_IDENTIFICATION=C   

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] knitr_1.39       magrittr_2.0.3   tidyselect_1.1.2 R6_2.5.1        
 [5] rlang_1.0.2      fastmap_1.1.0    fansi_1.0.3      dplyr_1.0.9     
 [9] tools_4.2.0      xfun_0.31        tinytex_0.39     utf8_1.2.2      
[13] cli_3.3.0        htmltools_0.5.2  ellipsis_0.3.2   remotes_2.4.2   
[17] yaml_2.3.5       digest_0.6.29    tibble_3.1.7     lifecycle_1.0.1 
[21] crayon_1.5.1     purrr_0.3.4      vctrs_0.4.1      glue_1.6.2      
[25] evaluate_0.15    rmarkdown_2.14   compiler_4.2.0   pillar_1.7.0    
[29] generics_0.1.2   vitae_0.5.1.9000 pkgconfig_2.0.3 
fmezerette commented 2 years ago

Hi,

I also have this problem on awesomecv after upgrading vitae from version 0.5.1 to 0.5.2. A downgrade to 0.5.1 resolved it.

From the .tex file, it seems the \makecvfooter function and arguments are not written after the \makecvheader in 0.5.2 compared to 0.5.1, even with show_footer: true specified in the YAML section.

Here is my sessionInfo() with vitae 0.5.1

R version 4.2.1 (2022-06-23 ucrt)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19044)

Matrix products: default

locale:
[1] LC_COLLATE=French_France.utf8  LC_CTYPE=French_France.utf8    LC_MONETARY=French_France.utf8 LC_NUMERIC=C                  
[5] LC_TIME=French_France.utf8    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] devtools_2.4.4 usethis_2.1.6 

loaded via a namespace (and not attached):
 [1] tidyselect_1.1.2    xfun_0.33           remotes_2.4.2       purrr_0.3.4         vctrs_0.4.1         generics_0.1.3     
 [7] miniUI_0.1.1.1      htmltools_0.5.3     yaml_2.3.5          utf8_1.2.2          rlang_1.0.5         pkgbuild_1.3.1     
[13] urlchecker_1.0.1    pillar_1.8.1        later_1.3.0         withr_2.5.0         glue_1.6.2          DBI_1.1.3          
[19] vitae_0.5.1         sessioninfo_1.2.2   lifecycle_1.0.2     stringr_1.4.1       htmlwidgets_1.5.4   evaluate_0.16      
[25] memoise_2.0.1       knitr_1.40          callr_3.7.2         fastmap_1.1.0       httpuv_1.6.6        ps_1.7.1           
[31] fansi_1.0.3         Rcpp_1.0.9          xtable_1.8-4        backports_1.4.1     promises_1.2.0.1    checkmate_2.1.0    
[37] BiocManager_1.30.18 cachem_1.0.6        pkgload_1.3.0       abind_1.4-5         mime_0.12           fs_1.5.2           
[43] rjson_0.2.21        digest_0.6.29       stringi_1.7.8       processx_3.7.0      dplyr_1.0.10        shiny_1.7.2        
[49] cli_3.4.0           tools_4.2.1         magrittr_2.0.3      tibble_3.1.8        profvis_0.3.7       crayon_1.5.1       
[55] pkgconfig_2.0.3     ellipsis_0.3.2      prettyunits_1.1.1   assertthat_0.2.1    rmarkdown_2.16      rstudioapi_0.14    
[61] R6_2.5.1            compiler_4.2.1   
elgabbas commented 2 years ago

I have the same problem

mitchelloharawild commented 2 years ago

This could be related to 6232043aff91b2d3c4b1fc327217b15239f6a0cc, investigating...

mitchelloharawild commented 2 years ago

Fixed in https://github.com/mitchelloharawild/vitae/commit/935d63d9863761bf5218530cf20e4aeece682599, thanks for your patience. I will be submitting this patch to CRAN shortly.