mitchelloharawild / vitae

R Markdown Résumés and CVs
https://pkg.mitchelloharawild.com/vitae/
1.23k stars 239 forks source link

Adding pronouns to vitae package #228

Closed isabelle-greco closed 1 year ago

isabelle-greco commented 1 year ago

Adding pronouns to each template.

isabelle-greco commented 1 year ago

@mitchelloharawild I think this one is almost done.

My only problem is with moderncv: I can't build the example even when pulling it from main. The error looks similar to #176: I suspect there is a

\renewcommand*{\researchidsocialsymbol}{{\small\aiResearcherID}~} 

line somewhere that I can't find causing issues. Can you build the moderncv from main?

mitchelloharawild commented 1 year ago

I've fixed up the icon not showing on moderncv and I'm not encountering the issue you describe when building from main. Would you like to add yourself to the package contributors?

isabelle-greco commented 1 year ago

@mitchelloharawild I added the changes to NEWS.md as per CONTRIBUTING.md - is that what you meant? (sorry if I've misunderstood, I've never contributed to an R package before).

mitchelloharawild commented 1 year ago

@mitchelloharawild I added the changes to NEWS.md as per CONTRIBUTING.md - is that what you meant? (sorry if I've misunderstood, I've never contributed to an R package before).

Great, thanks for adding the news entry. Even better that this is your first R package contribution! The DESCRIPTION file contains some metadata about the package, including the authors (similar to a paper). To acknowledge your contributions to this package, you're welcome to add yourself as a contributor to the package there.

https://github.com/mitchelloharawild/vitae/blob/935d63d9863761bf5218530cf20e4aeece682599/DESCRIPTION#L4-L9

Fill in the information as best you can, for example:

person("Isabelle", "Greco", role="ctb")

You can also add your ORCID if you have one :+1:

isabelle-greco commented 1 year ago

@mitchelloharawild I think it's all done! Woo! Thanks for all your help with this one - I've definitely learned so much about R packages along the way.

isabelle-greco commented 1 year ago

@mitchelloharawild Just bumping this PR - no rush at all but just wanted to make sure it wasn't forgotten!

isabelle-greco commented 1 year ago

No rush at all @mitchelloharawild - I just want to make sure this PR isn't forgotten. Currently waiting on approval for the workflows.

isabelle-greco commented 1 year ago

Woo the workflows have passed! Are you happy to merge this PR @mitchelloharawild?

isabelle-greco commented 1 year ago

Just bumping again @mitchelloharawild, I'd hate for this work to get forgotten!