search

mitchelloharawild / vitae

R Markdown Résumés and CVs
https://pkg.mitchelloharawild.com/vitae/
1.23k stars 239 forks source link

Generalise social icon inputs to use icon package #69

Open Dr-Joe-Roberts opened 5 years ago

Dr-Joe-Roberts commented 5 years ago

Many thanks for this very useful package!

I think it would be useful for academic users to be able to include additional links in the CV header other than the usual options of website, Twitter, etc. Would it be possible to incorporate Orcid, Publons, Google Scholar etc.?

mitchelloharawild commented 5 years ago

For orcid there's currently a PR being considered here: https://github.com/ropenscilabs/vitae/pull/64

More generally I'd like to integrate vitae with the icon package (https://github.com/mitchelloharawild/icon) which would allow you to use any icon / link in the header. This would be a fairly big change though, which will take some time (especially as the icon package still needs some work prior to release).

RLumSK commented 5 years ago

Would it possible to integrate the PR and similar changes for Publons and Google Scholar before integrating the icon package? This would give you more time to test and prepare the integration and in the meantime, others can use 'vitae' with the icons? Just an idea.

mitchelloharawild commented 5 years ago

Sure, if you'd like to provide a PR then that'd be fantastic.

RLumSK commented 5 years ago

Ok, I wasn't sure whether you want to integrate it or not. So I will update my PR with Publons and Google Scholar.

mitchelloharawild commented 4 years ago

Partially supported thanks to #64. This will likely need a more general method of inputting header/icon links.