mitchellspryn / UrdfSim

Other
102 stars 25 forks source link

simGetImages API does not accept image resolutions above 256x144 #54

Open InfraredLaser opened 3 years ago

InfraredLaser commented 3 years ago

When playing around with the image API I noticed that resolutions above 256x144 would not be saved or its image data not collected. When debugging it seems that simGetImages is only able to grab images at the default 256x144 resolution. Newer versions of AirSim resolved this issue, I'm hoping there could be a quick fix for this version of UrdfSim.

InfraredLaser commented 3 years ago

@mitchellspryn can the imaging API's be updated to resolve this issue?

mitchellspryn commented 3 years ago

I'm sure they can be :). I am currently busy with a bunch of other projects, and won't be able to take a look at this issue for some time.

InfraredLaser commented 3 years ago

The newer version of AirSim is capable of taking higher resolution images. I tried replacing the newer AirSim API's with UrdfSim's version, but I could not get the API's to work.

mitchellspryn commented 3 years ago

Yes, the two code bases have diverged quite a bit. So I would expect that there would need to be some engineering effort involved to get it right.

InfraredLaser commented 2 years ago

@mitchellspryn

So I had a further looked into this issue. It turns out that no matter how the camera defaults in settings.json are changed, UrdfSim will only take their default values. I'm thinking that if we find the location in the UrdfSim plugin which transfers the settings in settings.json to the PythonClient we can potentially resolve this issue.