Consolidation of functions, sanitize external script usage - Githubissues

mitchellurgero / openrsd

Open Raspberry Pi Server Dashboard

Apache License 2.0

39 stars 13 forks source link

Consolidation of functions, sanitize external script usage #18

Closed gnanet closed 6 years ago

gnanet commented 6 years ago

linked to login if session times out in page.php
moved redundant code into functions.php
replaced script calls with one-liner shell_exec and preg_match_all parsing
replaced interface parsing with ip addr show parsing
dashboard disk-free only lists "real" filesystems -t ext2 -t ext3 -t ext4 -t vfat -t xfs
conditional hide of PiVPN menu, if pivpn is missing

TODO:

collect functions from pages and app that can be moved to functions.php
move redundant class code into functions.php
organize collected functions into classes
optionally create separate php files for each class
run a php coding style lint