mitchlloyd / ember-screen

A screen size service for Ember
MIT License
50 stars 10 forks source link

Add Embroider support #12

Open rahulk94 opened 2 years ago

rahulk94 commented 2 years ago

Question Embroider is the latest build tooling for Ember applications which requires some addons to be updated to integrate with it correctly.

The Embroider team have requested that addon authors add Embroider support cases to their Ember-try configuration to find integration issues.

Is this something this project is interested in adding support for?

As I understand it, the first step towards support Embroider is upgrading this application to the Ember CLI 3.16 (or later) blueprint, and then adding Embroider builds to the Ember Try scenarios matrix.

Primarily raising for visibility at this stage but will probably become more and more important as more apps move to Embroider.

mitchlloyd commented 2 years ago

Thanks for including the links. I’ve heard about Embroider but haven’t actually used it so I’ll read up.

Overall it sounds like adding support is the right thing.