search

mitchlloyd / ember-screen

A screen size service for Ember
MIT License
50 stars 10 forks source link

PR to fix deprecation warning #5

Closed tarponjargon closed 6 years ago

tarponjargon commented 6 years ago

Haven't done this before, but I followed the direction from here:

https://discuss.emberjs.com/t/deprecation-warning-for-addons-future-big-problems/14204

luizcarraro commented 6 years ago

This should also fix: DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: project -> ember-screen -> ember-cli-babel

So +1 !

@mitchlloyd please consider this...

mitchlloyd commented 6 years ago

For some reason I thought I had commented on this earlier, but it seems I never did :/

@tarponjargon Thank you for this contribution! Looks great except that there are a few committed merge conflicts. Search for ======= and you should see them.

Subtletree commented 6 years ago

@tarponjargon Nice PR! Any chance you're able to remove those merge conflict remnants so we can get this into master?

tarponjargon commented 6 years ago

you can trash it - I just ran the codemod against the addon

viniciussbs commented 6 years ago

I'm also facing warnings from ember-screen.

dnstld commented 6 years ago

Any prevision to merge this? Thanks =)

raphaelns-developer commented 6 years ago

I'm also waiting for this merge.

iurikothe commented 6 years ago

Hi @mitchlloyd, could we have this baby merged soon? thanks!

charles commented 6 years ago

I'm waiting for this merge to. Thanks a lot @mitchlloyd

mitchlloyd commented 6 years ago

Thanks for letting me know this is a growing concern! Unfortunately this PR can't be merged because it has git conflict markers in it.

@luizcarraro, @viniciussbs, @dnstld, @raphaelns-developer, @iurikothe, @charles, do any of you have the inclination to run the updater against this project and open another PR? If not I may be able to find some time this weekend to do it.

mitchlloyd commented 6 years ago

Thanks to @raphaelns-developer for doing the heavy lifting on this one. I published this update to npm as ember-screen 1.0.0. 🎉