mitchmac / ServerlessWP

Host WordPress sites on Vercel, Netlify, or AWS Lambda
GNU General Public License v3.0
240 stars 85 forks source link

mv instead of cp #25

Closed notio-ca closed 9 months ago

notio-ca commented 10 months ago

Move a dir is faster and space saver on the container

mitchmac commented 9 months ago

Nice one, thank you!

mitchmac commented 9 months ago

I just reverted this merge for the time being. It results in the function logs containing many lines of "mv: cannot remove..." because /var/task/ is read-only.

notio-ca commented 9 months ago

Weird, I tested it and was working, so linux is coping instead of moving when the source is read only, So no value here I agree and we don't want the log to be flooded