search

mitchmalvin1 / pe

0 stars 0 forks source link

Trailing arguments when specifying the index for `update` #7

Open mitchmalvin1 opened 1 year ago

mitchmalvin1 commented 1 year ago

Screenshot 2023-04-14 at 4.51.51 PM.png

when the user runs the update command and is now trying to specify the index and the new question or answer, the trailing argument is not caught. This is an unintended behaviour that the author has not anticipated for

soc-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Certain words are ignored input

Input:

add [RANDOM WORDS] /q [QUESTION] /a [ANSWER]

add can be replaced with clear, help, review, bye

Expected:

The input is in an incorrect format.
You can view our user guide or type help to see the correct formats for commands.

==========================================================

Actual:

You have added the following card:
Q:[QUESTION]
A:[ANSWER]
==========================================================

Proof:

image.png

Cases where extra words are not ignored: list all [RANDOM WORDS]

image.png

Apologies if this is an intended behaviour.

[original: nus-cs2113-AY2223S2/pe-interim#2026] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is the intended behavior for the program to ignore the text not behind any option function (eg: /q). I believe that our user guide already indicates that when adding a question by add /q QUESTION /a ANSWER, only QUESTION and ANSWER would be recorded into the system.

The program tries its best to recover from user mistakes, by ignoring options that are not relevant to its operation, instead of throwing completely and forcing the user to retype. It doesn't allow typo so you can't get away with reviuw but it will ignore arguments it don't care if they exist, and that's entirely by design.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is different from the duplicate, the focus here should be in the line 1 q /q test. The other issue is on trailing arguments when running a command such as add. This bug is on specifying an index after the update command has been run.

They are two different bugs because the linked issue bug is regarding the parser library that fails to detect trailing arguments. But this bug has nothing to do with parser library, it only means that the user fails to manually check for trailing arguments that come after the index

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** This is different from the duplicate, the focus here should be in the line `1 q /q test`. The other issue is on trailing arguments when **running a command** such as `add`. This bug is on specifying an index after the `update` command has been run. They are two different bugs because the linked issue bug is regarding the parser library that fails to detect trailing arguments. But this bug has nothing to do with parser library, it only means that the user fails to manually check for trailing arguments that come after the index. This bug should be accepted because if user enter the index plus something else, the program **should not** actually delete the card as that is not supposed to be the correct behaviour nor do i think that it is an "intended behaviour" like the team likes to claim.