mitchmindtree / ofxNUI

A 3D, Generative, Nodal User Interface addon for openFrameworks
10 stars 1 forks source link

Code Review #1

Open bodusb opened 10 years ago

bodusb commented 10 years ago

First of all, excellent job. I did similar work in my master thesis from scratch.

But lets go to the points.

  1. ofxUI has changed some points, one of those is that they doesn´t have more the ofxUIEnvelope / ofxUIEnvelopEditor. So, or include in your own, or get out from the ofxNUIWidgetNode.
  2. Algebraic.h seems not necessary, it throws an error on VS2012, I commented it and worked fine.

I'm using you code in VS2012, W8.1, of0.8.4. Out of these points it is working fine. I'll be creating a simple example and I'would like, if you allow me to include in these.

I'm also experimenting with iGraph (http://igraph.org/) so I can draw others structures.

Well, nice job, and hope you let it be always available to oF community.

mitchmindtree commented 10 years ago

@bodusb thanks for the interest and kind words!

Unfortunately I haven't had the time to maintain this lately as I'm currently developing in Rust, however feel free to do a pull request with any fixes or updates you come across :)