Closed liquidgecka closed 10 years ago
Thanks! A couple questions:
Wow sorry. I wasn't getting emails for comments on pull requests or something. =)
So to answer your questions: Yes, and yes. =) I can fix both if you like. Generally I use a "when in rome" approach for tabs/spaces and such but if there is a defined preference let me know.
@liquidgecka thanks for replying. It'd be great if you could make those changes and pull request again and I'll pick it up quickly.
The WP coding guidelines specify tabs, fyi: http://make.wordpress.org/core/handbook/coding-standards/php/ It's of course possible that my original code wasn't up to code, though. :/
Looks like the change was in WP 3.6: http://wordpress.org/support/topic/will-jquery-migrate-be-officially-included-and-loaded-in-wordpress-36
The diff (sans whitespace) is here: https://github.com/mitcho/hookpress/pull/1/files?w=1#diff-2
When I updated the file I accidentally switched all the spaces to tabs.. I wasn't sure if that is what you wanted but I figured it couldn't hurt so please take a look. If you want me to trim the non impacted whitespace changes let me know.
Thanks!
After fighting with git svn for a while, I just pushed a new release on the wordpress plugins repo. Thanks again!
Thank you! This is a super useful plugin that we are using to automated actions on blog stuff. =)
Thanks for doing this. It seemed like it was getting dated. Just know there are lots of us zapier people out there using it and we appreciate your efforts.
jQuery removed the .live() call. This change replaces it with the .on() call.