search

mitcho / shibboleth

WordPress Shibboleth plugin
23 stars 23 forks source link

swapped 'split' for 'explode' for php7 compatibility #35

Closed dericcrago closed 7 years ago

jrchamp commented 7 years ago

21 contains this change and more.

dericcrago commented 7 years ago

@jrchamp - that's great, but #21 has been open for like a year now, right? For anyone looking for PHP 7 compatibility, I think swapping split for explode is the only necessary change. I don't really have a preference of how, but it'd be nice for https://wordpress.org/plugins/shibboleth/ to support PHP 7.

jrchamp commented 7 years ago

@dericcrago You are correct. I mentioned #21 so that anyone who arrives here might benefit from some of the other WordPress, PHP Notice and Multisite benefits present in that PR. Unfortunately, the plugin owners are not regularly responding to these requests. It would be nice to have an active maintainer added to the plugin.

srguglielmo commented 7 years ago

Or use a maintained plugin.

cough cough SimpleShib

(Disclaimer: I'm the author/maintainer of it)

michaelryanmcneill commented 7 years ago

Hello, thank you for reporting this issue. I released version 1.8 today to resolve this and other issues. I am the new maintainer of the plugin and all further work on the plugin will be done in a new GitHub repository. If you have any further issues, please don't hesitate to report them in the new repository.

dericcrago commented 7 years ago

thanks @michaelryanmcneill