search

mitcho / shibboleth

WordPress Shibboleth plugin
24 stars 23 forks source link

Fix Reauth Loop on Login Form; Load L10N Files #5

Closed jrchamp closed 10 years ago

jrchamp commented 10 years ago

Remove reauth argument to avoid destruction of session immediately after login. Add load_plugin_textdomain() call so that language overrides are used.

mitcho commented 10 years ago

Thanks for the PR. The l10n part looks perfectly fine. But can you explain the reauth issue? Under what circumstances would reauth be added? Does it actually clear the Shibboleth session or just the WP session? What is this a fix for? Thanks.

jrchamp commented 10 years ago

I clicked logout and went back to the WP login page. The reauth parameter was already in the URL (from WordPress I assume) and was being pulled into the URL in the Shibboleth login link. Clicking "Login with Shibboleth" kept taking me back to the WP login page until I removed the reauth argument.

mitcho commented 10 years ago

Ok, I could see how that would happen. I can't see this causing much damage so I'm going to merge it. Logging out still works properly as well?

jrchamp commented 10 years ago

Yeah, I didn't have any issues logging out (the WP page itself still has the reauth parameter set). This only modifies the Login with Shibboleth link.

On Wednesday, June 11, 2014, Michael Yoshitaka Erlewine < notifications@github.com> wrote:

Ok, I could see how that would happen. I can't see this causing much damage so I'm going to merge it. Logging out still works properly as well?

— Reply to this email directly or view it on GitHub https://github.com/mitcho/shibboleth/pull/5#issuecomment-45827033.

Jonathan Champ PHP Developer / Information Architect Distance Education & Learning Technology Applications (DELTA)

Email: jonathan_champ@ncsu.edu Phone: 919.513.0694

North Carolina State University Campus Box 7113, Venture II, Suite 500 Raleigh, NC 27695