search

mitcho / shibboleth

WordPress Shibboleth plugin
24 stars 23 forks source link

Fix WP_User constructor in shibboleth_authenticate_user #9

Open MrAlexWeber opened 9 years ago

MrAlexWeber commented 9 years ago

According to the WordPress documentation, the WP_User constructor takes User's ID, a WP_User object, or a user object from the DB. as its first parameter.

As I understand it, that means the plugin in this revision is trying to pass a username as this parameter, which will therefore never succeed to get the appropriate user data.

Passing 0 as the first parameter is the same as the default constructor, and fixes this error in my testing. source: http://developer.wordpress.org/reference/classes/wp_user/__construct/

michaelryanmcneill commented 6 years ago

Hello, thank you for reporting this issue. I released version 1.8 today to resolve this and other issues. I am the new maintainer of the plugin and all further work on the plugin will be done in a new GitHub repository. If you have any further issues, please don't hesitate to report them in the new repository.