search

mitchray / ample

A simple web browser client for Ampache
https://ample-player.vercel.app/
GNU Affero General Public License v3.0
61 stars 13 forks source link

[Bug] Column resize - All albums, index is off after Date? #19

Closed Jieiku closed 2 years ago

Jieiku commented 2 years ago

You can resize the first couple columns, but it gets weird when you use the handle just after the date header.

I would think the column header should line up with whats in the column, otherwise it gets a very disconnected appearance.

ample-all-albums-columns

Same issue, all Artists... maybe it is because of the controls column that does not have a header?

edit: nope I dont think that is the issue... seems to also do it on the genres page (the one that lists all genres)

mitchray commented 2 years ago

Dates & numbers are right-aligned, but the headers are all left-aligned

Is this what you mean?

Jieiku commented 2 years ago

Ah yes! thats whats happening. I think it would be more natural if the text in the header followed suit with whatever the column below does.

So if it is a number or date column then make the column header for those right aligned. (you could also try centering the header on the right aligned columns, and that might not feel so awkward.)

mitchray commented 2 years ago

I'll look at that for the next iteration of that component

Jieiku commented 2 years ago

Honestly, now that I understand whats happening I can use it easily enough, just gotta be careful to keep the number and date columns narrow. My brain just could not connect what was happening when I was resizing this, I thought it was broken.

mitchray commented 2 years ago

Come to think of it those kinds of fields don't really need to be resizable at all...

Updated in https://github.com/mitchray/ample/commit/2ba562ad7b5829a009238b030891a8ea8ad58991

Jieiku commented 2 years ago

I had considered that as well. Awesome, thanks.