mitchute / GLHE

MIT License
2 stars 3 forks source link

Removes CoolProp Dependency #86

Closed mitchute closed 6 months ago

mitchute commented 7 months ago

Removes the dependence on CoolProp and transitions to our own fluid properties library, SecondaryCoolantProps

mitchute commented 7 months ago

85 is upstream, so this should be merged afterward.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8805937936

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
glhe/profiles/temps_factory.py 3 4 75.0%
glhe/topology/ground_heat_exchanger_long_time_step.py 2 3 66.67%
glhe/topology/ground_heat_exchanger_short_time_step.py 4 6 66.67%
<!-- Total: 95 99 95.96% -->
Files with Coverage Reduction New Missed Lines %
glhe/utilities/functions.py 1 87.89%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 8805929124: -0.6%
Covered Lines: 2158
Relevant Lines: 2481

💛 - Coveralls
mitchute commented 7 months ago

A very unscientific look at the GitHub actions "Run Tests" action runtimes shows that previous PRs were averaging around 3:30 min, while this is approaching 2 min. 🚀