Closed Myoldmopar closed 5 months ago
Myoldmopar
commented
5 months ago OK, that's better. I'm still not sure what modified those ipynb files. Maybe I used an IDE refactor function and it thought it needed to update those in there. :shrug:
Either way, this is down to just some Python cleanup changes and should be able to drop right in. I'm done with cleanup here, ready to start cutting it down to the minimal version for translation.
coveralls
commented
5 months ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| glhe/standalone/plant_loop.py | 2 | 3 | 66.67% | ||
| glhe/topology/swedish_heat_pump.py | 5 | 6 | 83.33% | ||
| glhe/topology/ground_heat_exchanger_long_time_step.py | 0 | 2 | 0.0% | ||
| glhe/topology/ground_heat_exchanger_short_time_step.py | 1 | 5 | 20.0% | ||
| <!-- | Total: | 37 | 45 | 82.22% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| glhe/topology/ground_heat_exchanger_long_time_step.py | 1 | 48.86% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 8806014175: | 0.1% |
| Covered Lines: | 2155 |
| Relevant Lines: | 2474 |
Myoldmopar
commented
5 months ago I don't see a way to approve my own changes, so I'll just leave that to you @mitchute. Review/comment/approve/merge/delete whatever you'd like. I'll move onto the other project...
Miscellaneous things I found while getting more and more familiar with the codebase. I don't anticipate doing any more of these, the code looks great. Next step is carving out the pieces we need when we convert to C++.