mithi / epic-react-exercises

Practical React exercises with detailed solutions.
https://epic-react-exercises.vercel.app
Apache License 2.0
159 stars 36 forks source link

Bug: ties in TicTacToe exercise are registered as X wins #153

Closed idosius closed 1 year ago

idosius commented 1 year ago

Reproduction steps

  1. Open up the TicTacToe exercise: https://epic-react-exercises.vercel.app/react/hooks/1
  2. Play the game so that there is a tie

Expected result

The status should report that there's a tie.

Actual result

The status is: Winner: Player X 🎉🥳

Opera Snapshot_2023-04-14_122419_epic-react-exercises vercel app

mithi commented 1 year ago

Hi @idosius ,

This is not a tie. X is the clear winner

Screen Shot 2023-04-15 at 1 38 47 AM

below is a tie

Screen Shot 2023-04-15 at 1 41 56 AM
idosius commented 1 year ago

Sorry, my bad, should watch out what I open on Fridays :(