mithi / epic-react-exercises

Practical React exercises with detailed solutions.
https://epic-react-exercises.vercel.app
Apache License 2.0
159 stars 36 forks source link

(fix) Use _JSXStyle element instead of style #154

Closed mskeving closed 1 year ago

mskeving commented 1 year ago

The <style jsx global> tag is not properly transpiling to _JSXStyle, which blocks some of the exercises. Switching to _JSXStyle directly fixes the issue.

This change addresses the following issues: https://github.com/mithi/epic-react-exercises/issues/152, https://github.com/mithi/epic-react-exercises/issues/150, https://github.com/mithi/epic-react-exercises/issues/149, https://github.com/mithi/epic-react-exercises/issues/148.

Error seen:

Screen Shot 2023-04-17 at 1 57 23 PM

With update:

Screen Shot 2023-04-17 at 1 56 58 PM
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
epic-react-exercises ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 9:05pm
mithi commented 1 year ago

thanks. i’ve been meaning to fix it the the past year but unfortunately hadnt gotten around to it..

thanks! i’ll merge it today!

On Tue, Apr 18, 2023 at 5:04 AM vercel[bot] @.***> wrote:

The latest updates on your projects. Learn more about Vercel for Git ↗︎ https://vercel.link/github-learn-more Name Status Preview Comments Updated (UTC) epic-react-exercises 🔄 Building (Inspect https://vercel.com/mithi/epic-react-exercises/75jeRNodDKkk4ikP1KXrPkXPssmz ) Apr 17, 2023 9:04pm

— Reply to this email directly, view it on GitHub https://github.com/mithi/epic-react-exercises/pull/154#issuecomment-1512084450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMX2FKGQOWQSFXOVB45JQDXBWV7LANCNFSM6AAAAAAXBXINKA . You are receiving this because you are subscribed to this thread.Message ID: @.***>