mithi / hexapod-robot-simulator

A hexapod robot simulator built from first principles
MIT License
774 stars 109 forks source link

Web application UI tests #109

Open myiwt opened 4 years ago

myiwt commented 4 years ago

Hi

I've made some web automation tests for the UI checking that all links, text boxes and sliders are working. I've tried to do my best, but I am new at this so please do let me know if you'd like me to make further changes.

myiwt commented 4 years ago

Hi @mithi is it possible for me to re-submit the pull request? I've made changes to the code. Should I start a new pull request & clean up commits or re-submit it here?

mithi commented 4 years ago

Hi @mithi is it possible for me to re-submit the pull request? I've made changes to the code. Should I start a new pull request & clean up commits or re-submit it here?

@myiwt

Hey! Thanks for this pull request. I think you have already noticed that the PR is in sync with this branch; ie when you push requests to this branch your PR is also updated.

You can check why your build fails here, https://travis-ci.com/github/mithi/hexapod-robot-simulator/builds/182938302 and try to make the necessary changes.

I suggest you start with the following problem because it seems to be the most difficult:

Screen Shot 2020-09-09 at 1 46 56 PM Screen Shot 2020-09-09 at 1 47 09 PM

I think there's a problem with travis https://medium.com/@madhankumaravelu93/selenium-devops-series-run-your-scripts-in-travis-ci-b3505aaad367

I'll go try to see what I can do.

You can go try to fix the other issues! Thanks!

mithi commented 4 years ago

Hi again @myiwt !

I tried to make a couple of changes to the ci configuration file, but the current build is still failing, currently it is saying that the connection is being refused (see screenshot below)

Screen Shot 2020-09-09 at 3 56 03 PM

I think this has something to do with running chrome headless but i don't know exactly

I don't know how to fix this but I know the ci config file must be updated: https://github.com/mithi/hexapod-robot-simulator/blob/ff6f98ae1313b0c90bf40cb34376a6a57f2d1e40/.travis.yml

Here are some links that might be relevant to this issue:

I think if you get to solve this issue, then your pr will be merged. The other requirements are just a few cosmetic changes which you shouldn't need to worry about.

Thanks again for this pull request!

myiwt commented 4 years ago

Thanks so much for this @mithi, I'll have a look at it :)

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 8f76c0bf and detected 0 issues on this pull request.

View more on Code Climate.