search

mithi / hexapod-robot-simulator

A hexapod robot simulator built from first principles
MIT License
774 stars 109 forks source link

Ideas to improve code quality #81

Closed mithi closed 4 years ago

mithi commented 4 years ago

The variable trio isn't being used at all, should we even return it, or should we just return the n axis and the height?

https://github.com/mithi/hexapod-robot-simulator/blob/531fbb34d44246de3a0116def7e3d365de25b9f6/hexapod/ground_contact_solver/ground_contact_solver.py#L39

mithi commented 4 years ago

This function should be at the top of the file

https://github.com/mithi/hexapod-robot-simulator/blob/531fbb34d44246de3a0116def7e3d365de25b9f6/hexapod/ground_contact_solver/ground_contact_solver2.py#L52

mithi commented 4 years ago

Fixed with ee3c1dd