search

mithi / hexapod-robot-simulator

A hexapod robot simulator built from first principles
MIT License
768 stars 110 forks source link

Rename Point class to Vector #83

Closed mithi closed 4 years ago

mithi commented 4 years ago

We are using the Point class for 3d Vectors as well. I think the Point name is loaded, Vector is a more generalized term for a set of three numbers

guilyx commented 4 years ago

Could do that if you haven't been on it yet. Just renaming the class for every call and definition right ?

mithi commented 4 years ago

@guilyx sure, cool. I'll add you as a contributor in the README afterwards if you like.

Also let me know if you want me to take you off the assignees list in this issue in the case something came up and you wouldn't be able to do it. Thanks!

guilyx commented 4 years ago

Sure, I'll look around other issues as well, namely the quaternions ;)

mithi commented 4 years ago

Merged! 🎉🎉