Closed icyJoseph closed 4 years ago
Looks really good! It does look better on the right than at the bottom (or top). Thanks for putting an "id" prop as well, my previous implementation wasn't really good from an accessibility standpoint.
Thanks for removing the redundant react-router
as well. I didn't know about it until you pointed it out.
I should also just remove the labelTop
feature i.e. lines 16-19
and lines 24-28
since I don't think I'd ever want to use those functionality anymore. It does really look better when the text is on the right :)
Merging #100 into master will increase coverage by
0.03%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 78.96% 78.99% +0.03%
==========================================
Files 53 53
Lines 1217 1219 +2
Branches 142 144 +2
==========================================
+ Hits 961 963 +2
Misses 223 223
Partials 33 33
Impacted Files | Coverage Δ | |
---|---|---|
src/components/DimensionsWidget.js | 66.66% <ø> (ø) |
|
src/components/pages/ForwardKinematicsPage.js | 73.07% <ø> (ø) |
|
src/components/generic/SmallWidgets.js | 92.30% <100.00%> (+1.39%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fdb55d5...8fb09e1. Read the comment docs.
This one might not be wanted, but the x1/x5 indicators seemed a bit off, this PR places them to the right of the switch.
Also, this PR removes
react-router
as it is already installed byreact-router-dom
(runyarn why react-router
and you'll see)