codecov[bot]
commented
4 years ago Codecov Report
Merging #131 into master will decrease coverage by
0.17%. The diff coverage is78.43%.
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 75.83% 75.65% -0.18%
==========================================
Files 55 57 +2
Lines 1444 1442 -2
Branches 171 177 +6
==========================================
- Hits 1095 1091 -4
- Misses 303 305 +2
Partials 46 46 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/components/generic/SmallWidgets.js | 90.90% <ø> (ø) |
|
| src/components/pages/InverseKinematicsPage.js | 52.00% <0.00%> (ø) |
|
| src/components/pages/WalkingGaitsPage.js | 4.67% <0.00%> (ø) |
|
| src/components/vars.js | 100.00% <ø> (ø) |
|
| src/index.js | 0.00% <ø> (ø) |
|
| src/components/DimensionsWidget.js | 90.90% <50.00%> (ø) |
|
| src/components/pages/LegPatternPage.js | 68.42% <50.00%> (ø) |
|
| src/components/pages/ForwardKinematicsPage.js | 75.00% <66.66%> (ø) |
|
| src/components/HexapodPlot.js | 80.00% <77.77%> (-20.00%) |
:arrow_down: |
| src/AppHelpers.js | 81.25% <81.25%> (ø) |
|
| ... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 79010d9...253eb5e. Read the comment docs.
Performance is still not great, largely due to the huge overhead made by the Plotly library
There are some micro-optimizations that we can still do like lazy loading and memoization, using pure components, and preventing needless rerenderings, but these really won't make a difference unless we somehow address the overhead made by Plotly library.