search

mithi / hexapod

Blazing fast hexapod robot simulator for the web.
https://hexapod.netlify.app
Apache License 2.0
579 stars 70 forks source link

Custom plotly bundle error #136

Closed mithi closed 3 years ago

mithi commented 4 years ago

Custom Partial Plotly Bundle Split ( ~300kb ~115kb)

See also:

https://github.com/mithi/hexapod/issues/135

codecov[bot] commented 4 years ago

Codecov Report

Merging #136 into master will decrease coverage by 0.08%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   75.75%   75.67%   -0.09%     
==========================================
  Files          58       59       +1     
  Lines        1452     1455       +3     
  Branches      178      178              
==========================================
+ Hits         1100     1101       +1     
- Misses        306      308       +2     
  Partials       46       46
Impacted Files Coverage Δ
src/components/CustomPlot.js 0.00% <0.00%> (ø)
src/components/HexapodPlot.js 89.47% <100.00%> (+0.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdd2f1e...9abcc94. Read the comment docs.

mithi commented 4 years ago

https://deploy-preview-136--hexapod.netlify.app/

mithi commented 3 years ago

This custom plotly bundle is an attempt to reduce the overall bundle size, but customizing something that we don't know that much about could lead to various problems in the future. So I decided not to pursue this.