mithril-security / blindai

Confidential AI deployment with secure enclaves :lock:
https://www.mithrilsecurity.io/
Apache License 2.0
502 stars 36 forks source link

Cloud no root cert #125

Closed cchudant closed 2 years ago

cchudant commented 2 years ago

Description

Remove trusted root certificate :x: This is because, as it turns out, this is useless! We are using let's encrypt certificates, so the trusted root is actually already in the systems certificates. I thought grpc python did couldn't use systems certs, so I hardcoded the full chain (which is very bad if the server burns or anything else) until I found a better way / did our own CA) when i first implemented cloud. This should be merged & a new version of blindai python client should be released in order for the cloud to switch infrastructure (to swarm).

Related Issue

None

Type of change

How Has This Been Tested?

N/A

Checklist:

github-actions[bot] commented 2 years ago

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
621 508 82% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
client/blindai/client.py 79% 🟢
TOTAL 79% 🟢

updated for commit: 6aaf5a4 by action🐍

JoFrost commented 2 years ago

Looks good. I'll test the changes ASAP