Dev client exceptions - Githubissues

mithril-security / blindai

Confidential AI deployment with secure enclaves :lock:

https://www.mithrilsecurity.io/

Apache License 2.0

502 stars 36 forks source link

Dev client exceptions #8

Closed CerineBnsd closed 2 years ago

CerineBnsd commented 2 years ago

Added exception handling to the connect_server method

This pull request eliminates the boolean that was returned by the connect_server method and raises exceptions when errors occur.

Different errors are mapped to different exceptions types (see errors.py ) with custom error messages according to the action that raised the error.
setdefauttimeout is added before ssl.get_server_certificate, to handle cases when the server name exists but is not the correct one (doesn't correspond to a blindai server)
Debug mode allows seeing the whole error traceback and the original exception.

To do after validation

Edit documentation accordingly
Decide wether to raise exceptions in the other methods also, or to edit reply.ok to false (as it is right now)

CerineBnsd commented 2 years ago

@JoFrost Well noted, thank you. I'll make the requested changes today.

JoFrost commented 2 years ago

Closing this pull request, as it no longer makes sense because of the other pull request you made.