search

mitipi / serverless-ngrok-tunnel

Serverless plugin that creates ngrok public tunnel on localhost.
MIT License
9 stars 9 forks source link

Does serverless-ngrok-tunnel support serverless v3 and it's new parameters #11

Closed Adi33-cloud closed 2 years ago

Adi33-cloud commented 2 years ago

I was just wondering if this plugin will support serverless v3 and its new CLI commands and options soon. more specifically for the sls offline start --tunnel=true command https://www.serverless.com/framework/docs/guides/upgrading-v3

SSTPIERRE2 commented 2 years ago

It says Detected unrecognized CLI options: "--tunnel". on my end with serverless v3 and serverless offline v8.8.0

abhijeet-toptal commented 2 years ago

@nenadpnc do you plan to fix this error?

abhi-at-bitsy commented 2 years ago

any updates?

nenadpnc commented 2 years ago

If anyone is willing to submit the PR for this, i'll gladly review/accept it.

abhijeet-toptal commented 2 years ago

@nenadpnc here's the PR: https://github.com/mitipi/serverless-ngrok-tunnel/pull/12

abhi-at-bitsy commented 2 years ago

@nenadpnc can you please review and merge the PR?

abhi-at-bitsy commented 2 years ago

@nenadpnc any updates?

nenadpnc commented 2 years ago

Closed by #12