mitmath / computational-thinking

Course 18.S191 at MIT, Fall 2022 - Introduction to computational thinking with Julia
https://computationalthinking.mit.edu/
Other
2.61k stars 481 forks source link

hw1 quantize check #30

Open zmoon opened 4 years ago

zmoon commented 4 years ago

I feel like the check might be inadequate?

https://github.com/mitmath/18S191/blob/123040947d5b03a572b58c261b3009c8041b5c4e/homework/homework1/hw1.jl#L986-L1000

Since it is checking 0.3, floor with any digits ≥ 1 will pass, when really we want digits=1.

fonsp commented 4 years ago

Yep! Feel free to open a PR