mitmedialab / MediaCloud-Dashboard

Front-end for the MediaCloud database
https://dashboard.mediameter.org
Apache License 2.0
16 stars 6 forks source link

copy query bug #255

Closed hroberts closed 8 years ago

hroberts commented 8 years ago

There's a bug with the query copying bug that looks like it was introduced with the improved media addition feature. To reproduce:

The result for me on chrome is that the tag sets in the copied query are all 'undefined' instead of 'collection' and running the query gives an error because the tags_id_media clauses all look like this: "tags_id_media:None".

rahulbot commented 8 years ago

Yes, Anushka found the same bug yesterday.

Note to self: make sure all the collections properties are filled in for the common sources hard coded in. On Fri, Jun 17, 2016 at 2:25 PM Hal Roberts notifications@github.com wrote:

There's a bug with the query copying bug that looks like it was introduced with the improved media addition feature. To reproduce:

  • remove US MSM set
  • add U.S. Media super set
  • delete query b
  • copy query a into query b
  • click search

The result for me on chrome is that the tag sets in the copied query are all 'undefined' instead of 'collection' and running the query gives an error because the tags_id_media clauses all look like this: "tags_id_media:None".

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/c4fcm/MediaMeter-Dashboard/issues/255, or mute the thread https://github.com/notifications/unsubscribe/AApFmrUc1bSL7SsG6wGVR5j--1OaDqZNks5qMvS6gaJpZM4I4qNZ .

rahulbot commented 8 years ago

Fixed - was using TagModel instead of SimpleTagModel (70e0d4c356a09ca275217ab8ba113c63c71af935). Stupid old crusty code. I removed it (15e8f80d964812e4d14afe3390efdc22b4e8d4cc)