Closed boazsender closed 7 years ago
We should be consistent ALL CAPS vs Camel Case for Buttons " NEXT FACE" and Then "Next". Let's stick with Camel Case for the buttons "Next Face"
Good catch @joyab.
I think most all of the navigation buttons (vs the radio multi-select ones for example) are uppercase. Do you mind if I change "Next" to uppsercase instead of cameling all the other buttons?
I just pushed a commit to uppercase nextbutton in case that works for you @joyab.
If not, I can camel it back along with "Next Face", but would also recommend cameling the footer modal button, and perhaps global nav if we do that?
What do you think?
That works too!
On Mon, May 22, 2017 at 8:16 PM, Boaz notifications@github.com wrote:
I just pushed a commit to uppercase nextbutton in case that works for you @joyab https://github.com/joyab.
If not, I can camel it back along with "Next Face", but would also recommend cameling the footer modal button, and perhaps global nav if we do that?
What do you think?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bocoup/image-annotator/pull/226#issuecomment-303254412, or mute the thread https://github.com/notifications/unsubscribe-auth/ANjGUbHPDHrr6-4DDdVxWbuBxQkyp3dDks5r8iVRgaJpZM4Ni_m5 .
-- -- Joy Buolamwini MIT Media Lab - Graduate Researcher Founder - Algorithmic Justice League www.ajlunited.org
Portfolio: www.poetofcode.com Blog : www.medium.com/@Joy.Buolamwini Twitter: @jovialjoy http://www.twitter.com/jovialjoy @AJLUnited http://www.twitter.com/ajlunited Profile: Linkedin http://www.linkedin.com/in/buolamwini Skype: jbuolamwini
This is a partial completion of the tasks on #216.
This is ready for review, and to be merged.