Currently, if a note has frequency x which doesn't fit in the range [min,max] where min and max represent the extremes for frequencies of notes that are normally displayable in the sheet music, we set x to min or max for the purpose of sheet music visualization, depending on which end of the extreme x is on. This is a good temporary fix, and this fix would likely go unnoticed by a lot of users, but it may be confusing to hear multiple notes that clearly sound different but are displayed as the same in the sheet music. One potential thing we could do to distinguish these notes is color them red, perhaps. For now, there are print statements here: https://github.com/mitmedialab/prg-extension-boilerplate/blob/311c955b6262b26a1802e4bc588f4c88cd76926e/packages/scratch-vm/src/extensions/scratch3_musiccreation/sheetmusic.js#L912 and a little below it that show when a note is being adjusted.
DolevArtzi
commented
2 years ago
Currently, if a note has frequency
xwhich doesn't fit in the range[min,max]whereminandmaxrepresent the extremes for frequencies of notes that are normally displayable in the sheet music, we setxtominormaxfor the purpose of sheet music visualization, depending on which end of the extremexis on. This is a good temporary fix, and this fix would likely go unnoticed by a lot of users, but it may be confusing to hear multiple notes that clearly sound different but are displayed as the same in the sheet music. One potential thing we could do to distinguish these notes is color them red, perhaps. For now, there are print statements here: https://github.com/mitmedialab/prg-extension-boilerplate/blob/311c955b6262b26a1802e4bc588f4c88cd76926e/packages/scratch-vm/src/extensions/scratch3_musiccreation/sheetmusic.js#L912 and a little below it that show when a note is being adjusted.