Closed mewtaylor closed 1 year ago
It's a thing of beauty! Extension works great. I had a few issues with the tests not passing which I left a comment. I also left a few comments on (what else?!) comments...
I also would like for you to merge the latest dev
changes in (e.g. git pull && git merge origin/dev
).
^^ Merging dev
into a feature branch is another thing we should discuss being 'okay' for a reviewer todo (and only if they get conflicts would they call in the developer)
All in all, tons of fun seeing what you created, @mewtaylor ! I'm confident we'll get this merged tomorrow (Friday). 👍 👍 👍
New version of #248 without the fork!