search

mitmedialab / prg-raise-playground

Boilerplate for playing with and deploying Scratch 3.0 modifications!
https://mitmedialab.github.io/prg-extension-boilerplate/main/
MIT License
19 stars 40 forks source link

Feature: table labels #265

Open mewtaylor opened 1 year ago

mewtaylor commented 1 year ago

Redo of #264 - I think the branch naming convention I used was messing up tests!

pmalacho-mit commented 1 year ago

Redo of #264 - I think the branch naming convention I used was messing up tests!

Ah ya, I think the use of / confuses things (is that what you were thinking?).

pmalacho-mit commented 1 year ago

this looks good to me, @mewtaylor !! Nice work, shall I send it into dev, or do you have anything else you want to do with it?

mewtaylor commented 1 year ago

@pmalacho-mit yep! it messed up the rsync

mewtaylor commented 1 year ago

@pmalacho-mit hmm before you send it to dev, lemme check how loading the template for DoAI works, and if it breaks because it has existing tables but no table names. I'd love to have it cover old templates without needing to redo them again this close to DoAI day.

pmalacho-mit commented 1 year ago

@pmalacho-mit hmm before you send it to dev, lemme check how loading the template for DoAI works, and if it breaks because it has existing tables but no table names. I'd love to have it cover old templates without needing to redo them again this close to DoAI day.

Sounds good!! Totally makes sense. Let me know if you need any help.

mewtaylor commented 1 year ago

ok @pmalacho-mit confirmed that this does in fact break the existing templates for DPW and DoAI. I'm gonna think a bit about if it's worth it to adjust the extension to gracefully handle old projects or not, given the newness of the extension to begin with, and get back to ya.

In the meantime, let's hold off on merging this :).

pmalacho-mit commented 1 year ago

Sounds good @mewtaylor ! Were you able to diagnose the source of the errors on load? I wonder if there's a little bit of 'cleaning' you can do in the load handler to adrress the issues (say, if not having row / column names saved is causing the issues).

Let me know if you want to discuss, or if you want me to look at anything!

mewtaylor commented 1 year ago

@pmalacho-mit exactly, yup! And it isn't too cumbersome from a coding standpoint to not do it, so I added it here and that works :). I think with this fix we should be ok to merge, but take a look if you have a minute and lemme know what you think!