mitmproxy / mitmweb

GSoC Issue tracking for mitmweb.
11 stars 3 forks source link

Flow update changes list order #36

Closed mhils closed 8 years ago

mhils commented 8 years ago

Steps to reproduce:

  1. Add some flows
  2. Take a flow from the middle of the list
  3. Update it
  4. Flow gets moved to the bottom. :-(

The issue is that https://github.com/mitmproxy/mitmproxy/blob/master/web/src/js/ducks/utils/list.js currently implements updates as remove-then-add. This breaks if no sort function is specified and we rely on natural list ordering.