mito-ds / mito

The mitosheet package, trymito.io, and other public Mito code.
https://trymito.io
Other
2.3k stars 160 forks source link

mitosheet: set default_apply_formula_to_column #1289

Closed aarondr77 closed 8 months ago

aarondr77 commented 8 months ago

Description

Let Streamlit app developer set the default cell editor to individual cell.

Testing

See tests + existing test "'Edit individual cell only applied to edited cell and preserves formula and toggle on next open of cell editor'"

Documentation

Yes -- we need to add documentation to the streamlit api

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 11:44pm
naterush commented 8 months ago

Actually, realized that this is a public API -- and it's actually really confusingly named. default_apply_formula_to_column and then a boolean variable is almost optimized to confuse the user.

We don't have to refactor all the internals, but can we change the public api to: `default_editing_mode=Literal['cell', 'column']`` I think this is way more clear!

naterush commented 8 months ago

If you edit through the formula bar, it doesn't pick up the default editing mode. Is this intended?