Fullscreen Doesn't Work on <iframed>'ed Streamlit Mitosheet

mito-ds / mito

The mitosheet package, trymito.io, and other public Mito code.

Other

2.28k stars 154 forks source link

Describe the bug Click on fullscreen button (top right corner) does nothing. Currently having 3 monitors, and naturally I would need the fullscreen button to fill mitosheet to the monitor it's residing on (same screen as the browser). Also tried the demo one on https://www.trymito.io/ and having same issue. I also use streamlit 1.36.0 if that's any help.

To Reproduce Click on Full screen button. May only affect multiple monitors.

Expected behavior Fill entire viewport.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: Arch Linux
Browser [e.g. Chrome, Firefox]
Mito Version 0.1.577

Additional context Add any other context about the problem here. I haven't tested on single monitor setup.

Tried on single monitor. I have to hit Fullscreen next to "Built with Streamlit" then it works. So this is the issue of me using to embed streamlit with mito app. Any fix for this?</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

mito-ds / mito

Fullscreen Doesn't Work on <iframed>'ed Streamlit Mitosheet #1317