search

mito-ds / mito

The mitosheet package, trymito.io, and other public Mito code.
https://trymito.io
Other
2.3k stars 160 forks source link

Jupyterlab 4 manually #1319

Closed aarondr77 closed 1 month ago

aarondr77 commented 3 months ago

Description

Adds support for Jupyter Lab 4 and Notebook 7.

The Jupyter team did amazing work to unify Notebook 7 and Jupyter Lab 4. Now, Notebook 7 runs on top of Jupyter Lab. That means, we don't need separate extensions for each environment. This let us delete a bunch of confusing code that was previously required to support both Jupyter Lab and notebooks.

Before merging, we need to release a new major package version to make it clear which versions of Mito support Jupyter Lab 3.x / Notebook 6.x and which versions support Jupyter Lab 4.x / Notebook 7.x

Testing

See the tests + run in Jupyter Lab 4 and Notebook 7.

Documentation

Yes -- we need to update our docs so that users know which version of Mito to install.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 4:01pm
aarondr77 commented 3 months ago

Bug

When creating a new mitosheet, it overwrites the code cell directly below instead of inserting a new one for generated code.

Add a frontend test for this.

This exists in our Jupyter Lab 3.x deployed version. I opened an issue for it here: https://github.com/mito-ds/mito/issues/1320