mitodl / bootcamp-ecommerce

MIT Bootcamp e-commerce
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

Product Page: Alumni section #443

Closed odlbot closed 4 years ago

odlbot commented 4 years ago

As a bootcamp applicant, I'd like to see testimonials from past alumni.

Acceptance Criteria

Out of scope

┆Attachments: Alumni wireframe | https://projects.invisionapp.com/prototype/MIT-Bootcamps-Wireframe-sketch-ck9vklrqz008w0q01ud3k6a52/play/6eb34faf | https://projects.invisionapp.com/prototype/MIT-Bootcamp-Desktop-Design-ck9zigyjv000bir01b0tb3dbd/play/87d0e06b | https://projects.invisionapp.com/prototype/MIT-Bootcamp-Mobile-Design-ck9zifqyk0003w801qmnlnc1j/play/e3ba429a | bootcamp-ecommerce #509 add product page: alumni section

odlbot commented 4 years ago

➤ Umar Asghar commented:

pdpinch just a few questions here.

Invision attached design doesn't talk about either of browser width image or title (default value of "Alumni"). What does it mean? Is it not needed?

The design is incomplete, a few concerns here that

odlbot commented 4 years ago

➤ Peter Pinch commented:

I added an InVision link ( https://projects.invisionapp.com/prototype/MIT-Bootcamp-Desktop-Design-ck9zigyjv000bir01b0tb3dbd/play/87d0e06b ) for the updated design. I think you can see now where the background image goes and the "Alumni" title.

As far as I know, there will be only one alumni displayed. I'll try to get that clarified.

I also added a link to the mobile design ( https://projects.invisionapp.com/prototype/MIT-Bootcamp-Mobile-Design-ck9zifqyk0003w801qmnlnc1j/play/e3ba429a )

We don't usually put in the effort to do a tablet design -- there's just not that many users, and usually the engineer can find a reasonably solution between the mobile and the desktop designs. If that's not working for you, include screenshots on your PR and ask for help.

odlbot commented 4 years ago

➤ Umar Asghar commented:

It does not make sense that we have Alumni from 100+ countries over the globe but we will be showing only one.

But I will show only one as per my understanding over the data model it will have the option of adding multiple alumni from cms that's what I understood from the ticket description. As far as design covers only one alumnus so on the page I will be listing down only the first one.

Please let me know if I'm wrong.