mitodl / ccxcon

CCXCon API
GNU Affero General Public License v3.0
7 stars 0 forks source link

Added status view #101

Closed giocalitri closed 8 years ago

giocalitri commented 8 years ago

Fixes #29

justinabrahms commented 8 years ago

I'll say the same thing I said to George.

Instead of copying this code from repo to repo, we should just put it in a python package and take it on as a dependency. This would be generally useful to the community at large and useful for us in particular, as we would benefit from only performing updates in a single place.

justinabrahms commented 8 years ago

(also, like I told George, if you feel like this is pressing and we don't have time to deduplicate code, then a begrudging :+1:)

giocalitri commented 8 years ago

I'll let @pdpinch decide

justinabrahms commented 8 years ago

For his reference: https://github.com/mitodl/lore/blob/master/status/views.py#L36 https://github.com/mitodl/teachersportal/blob/master/portal/views/status.py#L31

pdpinch commented 8 years ago

I thought you guys told me this morning that there actually some significant differences between the ccxcon and teachersportal versions of this -- because of a different range of services that needed to report status?

justinabrahms commented 8 years ago

No. They are identical. CCXCon has more checks it will need to do (including redis checking), but it's a strict superset.

Also, that redis checking is in lore too, iirc.

On Mon, Jan 11, 2016 at 3:36 PM, Peter Pinch notifications@github.com wrote:

I thought you guys told me this morning that there actually some significant differences between the ccxcon and teachersportal versions of this -- because of a different range of services that needed to report status?

— Reply to this email directly or view it on GitHub https://github.com/mitodl/ccxcon/pull/101#issuecomment-170682238.

giocalitri commented 8 years ago

@pdpinch The difference is just in the services that are tested in the view.