Closed justinabrahms closed 8 years ago
Fixes #91?
You don't need to change the description here but some notes for future documentation:
I have successfully run through the manual steps, onto the code review
Is Celery delegating out tasks to workers? I'm seeing everything run in the web container, not the celery container (cc @bdero )
Migrations work fine
This is out of the scope for this PR but we should consider disabling PATCH/PUT/DELETE on courses and also POST for modules, if no client has a reasonable use for them, so we don't have to worry about handling those cases. (#97)
When I POST an incorrect course id to courses I get an immediate retry failure instead of the exponential backoff. I think this is related to celery tasks running in the web process instead of in their own workers
Overall this looks good. I feel like the Celery issue is a configuration problem, any insight @bdero?
I agree that this is a configuration error. We're currently doing eager celery running, which means that it executes in-process as a blocking request. If we swap up CELERY_ALWAYS_EAGER
to False, it'll use the celery container.
We should change it to be False except in tox.ini because only tests should need the eager functionality. I'll file a ticket for that
Looks good to me (remember to squash!) :+1:
What's this PR do?
Adds support for fetching course structure (aka Modules) from the edx API.
Where should the reviewer start?
courses/tasks.py
How should this be manually tested?
./manage.py shell
and trigger a save on the course you want to trigger an update for. Ensure it has a validcourse_id
.course.module_set.all()
should return a list of that course's modules in order.Any background context you want to provide?
I've moved edx_instance to it's own fully-formed model so we can store additional OAuth information. This is in a new app called
oauth_mgmt
.You can now exclude slow tests with
-m \"not slowtest\"
which will skip dredd from running.What are the relevant tickets?
Fixes #91 #9 #5
What gif best describes this PR or how it makes you feel?