search

mitodl / edx-platform

The Open edX platform, the software that powers edX!
http://open.edx.org/
GNU Affero General Public License v3.0
6 stars 1 forks source link

making LOGIN_REDIRECT_WHITELIST variable configurable through lms.yml #238

Closed HamzaIbnFarooq closed 3 years ago

HamzaIbnFarooq commented 3 years ago

Related Ticket

https://github.com/mitodl/mitxpro/issues/1931

What this PR does

LOGIN_REDIRECT_WHITELIST variable wasn't getting picked from lms.yml, this PR solves the bug and makes the variable easily configurable.

pdpinch commented 3 years ago

Should we try to get this merged upstream at edX?

I don’t really understand what it does.

On Feb 4, 2021, at 5:36 AM, Hamza Farooq notifications@github.com wrote:

Merged #238 https://github.com/mitodl/edx-platform/pull/238 into xpro/koa.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mitodl/edx-platform/pull/238#event-4290123116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADJALQPW4BA4YHALHVOWCTS5J2CZANCNFSM4W6TL67Q.

HamzaIbnFarooq commented 3 years ago

Should we try to get this merged upstream at edX?

Yes, I was thinking the same about it.

I don’t really understand what it does.

A variable named LOGIN_REDIRECT_WHITELIST wasn't getting picked from environment files (lms.yml), this PR solves the bug and makes the variable easily configurable through environment variables. So technically, doesn't do much but indeed required.